fix(registry): handle empty targets in TXT records logging an error #5148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5129
Context:
TXT
record with routing policy on GCP has no direct single target, as a result, the direct index access to first element fails. (Such routing policy based records not necessarily be part of the external dns management area, it could be created or updated manually that can cause this issue.)How to test manually:
Let the external-dns run as is , the google DNS zone you are using , create a TXT record with weighted routing policy.
Current version should crash with the error in the issue.
in the PR changes will make sure it gets passed by, with a error line like below
Checklist