-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): generate docs/monitoring/metrics.md file #5117
chore(docs): generate docs/monitoring/metrics.md file #5117
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
/label tide/merge-method-squash |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Overall PR LGTM. It's the case for the chart and it's clearly easier to review & update. |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Changed to a template file. |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add CI on this ? (like for flags)
On my system, it generates two additional metrics:
diff --git a/docs/monitoring/metrics.md b/docs/monitoring/metrics.md
index 6c7782af..effbd242 100644
--- a/docs/monitoring/metrics.md
+++ b/docs/monitoring/metrics.md
@@ -80,6 +80,8 @@ curl https://localhost:7979/metrics
| http_request_duration_seconds |
| process_cpu_seconds_total |
| process_max_fds |
+| process_network_receive_bytes_total |
+| process_network_transmit_bytes_total |
| process_open_fds |
| process_resident_memory_bytes |
| process_start_time_seconds |
The Go runtime's behavior differs considerably across systems due to factors like Docker containerization, the host operating system, and architecture (ARM, AMD64, etc.). This inconsistency is why its tests are disabled. We can either add them manually or remove them entirely.
|
I'm unsure how to catch them from within a code, they are only available when |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
I've added manually this two metrics. It's a best effort at the moment. |
Current behaviour for CI tests
|
Need guidance here. |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* master: (198 commits) fix(aws-sd): service instances registration and deregistration (kubernetes-sigs#5135) chore(docs): generate docs/monitoring/metrics.md file (kubernetes-sigs#5117) feat(chart): add helm-unittest framework (kubernetes-sigs#5137) feat(chart): add helm-unittest framework feat(aws): always create AAAA alias records in route53 (kubernetes-sigs#5111) feat(aws): fetch zones with tags batching (kubernetes-sigs#5058) docs: openwrt webhook (kubernetes-sigs#5132) docs(proposal): ipv6 internal node ip rollback plan (kubernetes-sigs#5081) docs(proposal): update date format chore(deps): bump the dev-dependencies group across 1 directory with 7 updates Update README.md with proper link to dev guide Add OpenStack Designate webook provider to readme chore(deps): bump the dev-dependencies group with 3 updates chore(deps): bump the dev-dependencies group with 20 updates chore(deps): bump azure/setup-helm in the dev-dependencies group style: formatting fix: remove broken test fix test name chore: upgrade ExternalDNS to go 1.24 chore-makefile-coverage ...
Description
No issue. On one of the proposals, there were mentioning about metrics #5079 (comment). So I've tried to understand how metrics/observability is configured. Turns out, that there were no page about that, only FAQ with outdated data.
This pull request is very similar to #4983
It adds
This PR is massive, I'm could split it if required, just need a guidance how to slice it.
Checklist