Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): added renovate config for custom regexes #4978

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat(deps): added renovate config for custom regexes #4978

wants to merge 9 commits into from
+86 −0

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Dec 28, 2024 •
edited
Loading

Description

  • Added renovate configuration. It automate dependency updates, quite similar to Dendabot, but it does provide more flebilities and support custom package updates.

Fixes #4973

Result on forked repo https://github.com/ik-workshop/external-dns-fork-renovate-bootstrap/pull/24/files

How to onboard

I'll share config how to onboard. Onboarding very similar to Dependabot as well.

Go to Github App

Screenshot 2024-12-28 at 12 37 36

Allow Renovate to access required repo. No credentials required

Screenshot 2024-12-28 at 12 38 36

Trust Renovate App

Screenshot 2024-12-28 at 12 38 47

You can access UI as well

Screenshot 2024-12-28 at 12 39 36

Check the logs of a recent job

Screenshot 2024-12-28 at 12 39 43

Regex used in config

Screenshot 2024-12-28 at 13 04 36

Checklist

  • Unit tests updated
  • End user documentation updated

@ivankatliarchuk
chore: added renovate config
5c12bda 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ivankatliarchuk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@mloiseleur
Copy link
Contributor

mloiseleur commented Dec 30, 2024 •
edited
Loading

That sound good to me.
Before I start reviewing this PR, @Raffo wdyt of this approach ? For the onboard, do you know if it's possible to use GitHub App on kubernetes-sigs ?

@Raffo
Copy link
Contributor

Raffo commented Dec 30, 2024

I don’t think we should proceed with this. We don’t have permissions to do changes like adding apps and I don’t see a lot of problems with dependabot. Updating the version docs like in the linked PR is really no hassle compared to what we have to pull off every time we do a release due to the constraints that the kubernetes flow imposes to us.

@ivankatliarchuk
Copy link
Contributor Author

So you would not consider renovate as a github action? I do get that there are multiple steps, and not all of them are simple. But step-by-step you could automate pretty much everything and make it quite safe at the same time too.

@Raffo
Copy link
Contributor

Raffo commented Jan 2, 2025

@ivankatliarchuk sorry, I misunderstood. I'm okay with the action, but I don't think we should fully switch to renovate, dependabot is working quite fine for us for regular dependency updates and we won't be enabling other github apps on this repo.

@ivankatliarchuk ivankatliarchuk changed the title chore: added renovate config WIP chore: added renovate config Jan 2, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 2, 2025 15:50
@ivankatliarchuk ivankatliarchuk mentioned this pull request Jan 3, 2025
Closed
11 tasks
@ivankatliarchuk
Copy link
Contributor Author

Could be related. kubernetes/org#5126

Need to spend a bit more time on that one to understand current permissions and security concerns if any

@ivankatliarchuk
Copy link
Contributor Author

So renovate as integration is not allowed at the moment

  1. REQUEST: New integration for kubernetes-sigs/gcp-compute-persistent-disk-csi-driver kubernetes/org#4501
  2. REQUEST: New integration for kubernetes-sigs/gcp-filestore-csi-driver kubernetes/org#4502

The github action job seems like no restrictions, but still digging

ivankatliarchuk and others added 6 commits March 3, 2025 14:01
@ivankatliarchuk
feat(chart): add helm-unittest framework
82c7860 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
Merge branch 'kubernetes-sigs:master' into master
26f1243
@ivankatliarchuk
Merge branch 'kubernetes-sigs:master' into master
8a3691d
@ivankatliarchuk
Merge branch 'kubernetes-sigs:master' into master
66a3885
@ivankatliarchuk
Merge branch 'master' into chore/added-renovate
a4e72e1 
* master: (198 commits)
  fix(aws-sd): service instances registration and deregistration (kubernetes-sigs#5135)
  chore(docs): generate docs/monitoring/metrics.md file (kubernetes-sigs#5117)
  feat(chart): add helm-unittest framework (kubernetes-sigs#5137)
  feat(chart): add helm-unittest framework
  feat(aws): always create AAAA alias records in route53 (kubernetes-sigs#5111)
  feat(aws): fetch zones with tags batching (kubernetes-sigs#5058)
  docs: openwrt webhook (kubernetes-sigs#5132)
  docs(proposal): ipv6 internal node ip rollback plan (kubernetes-sigs#5081)
  docs(proposal): update date format
  chore(deps): bump the dev-dependencies group across 1 directory with 7 updates
  Update README.md with proper link to dev guide
  Add OpenStack Designate webook provider to readme
  chore(deps): bump the dev-dependencies group with 3 updates
  chore(deps): bump the dev-dependencies group with 20 updates
  chore(deps): bump azure/setup-helm in the dev-dependencies group
  style: formatting
  fix: remove broken test
  fix test name
  chore: upgrade ExternalDNS to go 1.24
  chore-makefile-coverage
  ...
@ivankatliarchuk
chore(deps): added renovate
31fa58a 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review March 6, 2025 09:10
@ivankatliarchuk
Copy link
Contributor Author

Hi @Raffo wdyt? I found no evidences that GitHub Actions are not allowed.

@ivankatliarchuk
Copy link
Contributor Author

Example pull-request ik-workshop#39

@ivankatliarchuk
Copy link
Contributor Author

With renovate we only do custom regexes and pre-commit, as it's not supported. So only features that not yet supported by dependabot dependabot/dependabot-core#1524, it's not a replacement of dependabot

@ivankatliarchuk ivankatliarchuk changed the title WIP chore: added renovate config feat(deps): added renovate config for custom regexes Mar 6, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
@ivankatliarchuk
chore(deps): added renovate
3d91680 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
chore(deps): added renovate
ee2bd0d 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivankatliarchuk @k8s-ci-robot @mloiseleur @Raffo