Skip to content

Commit

Permalink
If one source fails, continue to the next source instead of bailing
Browse files Browse the repository at this point in the history
  • Loading branch information
Ole Markus With committed Sep 7, 2022
1 parent 819f61e commit 352cf68
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion source/multisource.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package source
import (
"context"

log "github.com/sirupsen/logrus"
"sigs.k8s.io/external-dns/endpoint"
)

Expand All @@ -35,7 +36,8 @@ func (ms *multiSource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, err
for _, s := range ms.children {
endpoints, err := s.Endpoints(ctx)
if err != nil {
return nil, err
log.Errorf("failed to collect endpoints for source %T: %v", s, err)
continue
}
if len(ms.defaultTargets) > 0 {
for i := range endpoints {
Expand Down

0 comments on commit 352cf68

Please sign in to comment.