Add virt capacity benchmark test #180
Conversation
ygalblum
force-pushed
the
capacity-benchmark
branch
2 times, most recently
from
79662a2 to
e1c8ba7
Compare
ygalblum
force-pushed
the
capacity-benchmark
branch
4 times, most recently
from
8388e87 to
68f1b43
Compare
common.go
Outdated
| @@ -70,3 +90,175 @@ func GatherMetadata(wh *workloads.WorkloadHelper, alerting bool) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // GenerateSSHKeyPair generates an SSH key pair and saves them to the specified files | |||
| func generateSSHKeyPair(sshKeyPairPath string) (string, string, error) { | |||
There was a problem hiding this comment.
Can this go into go-commons please? Looks like nice function to be reused across our tooling.
common.go
Outdated
| return getVolumeSnapshotClassNameForProvisioner(provisioner) | ||
| } | ||
|
|
||
| func virtctlExists() bool { |
There was a problem hiding this comment.
Some of the functions in this file seem to be commonly used across all the virtualization portifolio. Can we move all of them to go-commons please?
ygalblum
force-pushed
the
capacity-benchmark
branch
from
68f1b43 to
b101dca
Compare
|
I've updated the code. However, it now depends on changes made in https://github.com/cloud-bulldozer/go-commons/. Once the all changes are merged and the dependency is updated here, this code change will compile successfully |
ygalblum
force-pushed
the
capacity-benchmark
branch
3 times, most recently
from
d512e42 to
b6fd4ac
Compare
| - name: create-vms | ||
| jobType: create | ||
| jobIterations: 1 | ||
| qps: 20 |
There was a problem hiding this comment.
curious why in the first job you have the CNV default of 5/10 for QPS/Burst -- but here and further down you default to 20/20?
There was a problem hiding this comment.
TBH I didn't put too much thought into it. Especially since most of the jobs are pretty small. So, not sure it even matters. Which values would you recommend here?
ygalblum
force-pushed
the
capacity-benchmark
branch
from
b6fd4ac to
5d3ac5a
Compare
|
@vishnuchalla I've added nobs that allow skipping some checks and setting some values so that the test can pass with the CI cluster. Hopefully the test will pass in the CI as well (along with the checks I've added) |
ygalblum
force-pushed
the
capacity-benchmark
branch
2 times, most recently
from
30c1822 to
801fbe3
Compare
ygalblum
force-pushed
the
capacity-benchmark
branch
from
801fbe3 to
704f3a8
Compare
|
The CI is failing because the |
ygalblum
force-pushed
the
capacity-benchmark
branch
3 times, most recently
from
8550825 to
c6c9941
Compare
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
force-pushed
the
capacity-benchmark
branch
from
c6c9941 to
b744a58
Compare
|
@vishnuchalla PTAL. I solved the CI issue by changing the script so that it will work also on |
Type of change
Description
Run Virtualization with Storage Capacity Benchmark test