Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support generics and forward references #272

Merged
merged 27 commits into from
Jan 28, 2025
Merged

support generics and forward references #272

merged 27 commits into from
Jan 28, 2025

Conversation

mciszczon
Copy link
Collaborator

@mciszczon mciszczon commented Jan 27, 2025

Closes #131 #160 #250

To close #259

@mciszczon mciszczon self-assigned this Jan 27, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: b20329c Previous: 1cdc3ef Ratio
tests/performance/test_from_dict.py::test_casting 140328.6592434538 iter/sec (stddev: 0.0000020240917045147896) 184957.82267943013 iter/sec (stddev: 5.927125345458689e-7) 1.32

This comment was automatically generated by workflow using github-action-benchmark.

@mciszczon
Copy link
Collaborator Author

@avlonder any idea for a better exception message in generics.py:20 (raise DaciteError("Generics error"))?

@avlonder
Copy link
Contributor

@avlonder any idea for a better exception message in generics.py:20 (raise DaciteError("Generics error"))?

What about an f-string "Ambiguous TypeVar {var_name}"?

@mciszczon
Copy link
Collaborator Author

@avlonder any idea for a better exception message in generics.py:20 (raise DaciteError("Generics error"))?

What about an f-string "Ambiguous TypeVar {var_name}"?

I guess that could do! Thanks for all the contributions, I'll release 1.9.0 in the upcoming days :)

@mciszczon mciszczon merged commit 9fa6a84 into master Jan 28, 2025
7 checks passed
@mciszczon mciszczon deleted the feature/generics branch January 28, 2025 07:58
@mciszczon mciszczon mentioned this pull request Jan 28, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sdist for dacite==1.8.1 Possible bug: Cannot load dataclasses with members of defined generic type
3 participants