Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing constexpr and device annotation for mapping ctors #382

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Feb 24, 2025

Add missing constexpr and device annotation. Quoting p2642

template<class LayoutLeftPaddedMapping>
constexpr explicit(! is_convertible_v<typename LayoutLeftPaddedMapping::extents_type, extents_type>)
mapping(const LayoutLeftPaddedMapping&) noexcept;

And

template<class LayoutLeftPaddedMapping>
constexpr explicit(! is_convertible_v<typename LayoutLeftPaddedMapping::extents_type, extents_type>)
mapping(const LayoutLeftPaddedMapping& other) noexcept;

Review of @dalg24

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
@dalg24 dalg24 merged commit 74036ad into kokkos:stable Feb 26, 2025
15 checks passed
@tpadioleau tpadioleau deleted the fix-missing-ctor-annotations branch February 28, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants