Add fetchcontent for google benchmark #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SE_SYSTEM_BENCHMARK defaulted to On (to preserve previous behavior) to use a system-provided library instead
mhoemmen
approved these changes
Feb 14, 2025
mhoemmen
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way of getting google benchmark via FetchContent.
I added a flag
MDSPAN_USE_SYSTEM_BENCHMARKto control whether to use a system-provided library or not. As the previous behavior was to use a system library, I defaulted this toOn(which is the opposite of what we do for googletest). I'm open to changing the default toOffif we think that is more desirable.