Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with pragma unroll in laswp #2525

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Mar 6, 2025

The current guards are not appropriately working on Blake.
Adding the standard Kokkos guard for pragma unroll does the job

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
@lucbv lucbv added bug Cleanup Code maintenance that isn't a bugfix or new feature labels Mar 6, 2025
@lucbv lucbv requested a review from brian-kelley March 6, 2025 16:05
@lucbv lucbv self-assigned this Mar 6, 2025
@lucbv lucbv requested a review from yasahi-hpc March 6, 2025 16:07
@lucbv lucbv merged commit 820a5a1 into kokkos:develop Mar 6, 2025
19 checks passed
@lucbv lucbv deleted the guard_pragma_unroll branch March 6, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants