-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL: Fix Test_Common_AlignPtrTo.hpp #2506
SYCL: Fix Test_Common_AlignPtrTo.hpp #2506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still fails with oneapi-2023.1.0, can you guard the change to they only apply when compiling with your version of oneapi or later?
For reference here is the output on our local testing machine:
|
@cwpearson Do we really care about this test? It's my understanding that it check for an implementation that isn't used in |
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
048f2bc
to
8479c62
Compare
Still failing on the same test but with the serial backend, please revert back to the original logic, just add the condition: |
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Here you go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay that looks good and was tested with oneapi 2023 and 2025
According to https://my.cdash.org/tests/255304660, this works with recent
oneAPI
compiler versions.