Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL: Fix Test_Common_AlignPtrTo.hpp #2506

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

masterleinad
Copy link
Contributor

According to https://my.cdash.org/tests/255304660, this works with recent oneAPI compiler versions.

@cwpearson cwpearson added the AT2-CI-APPROVAL Approve CI to run at SNL label Feb 21, 2025
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still fails with oneapi-2023.1.0, can you guard the change to they only apply when compiling with your version of oneapi or later?

@lucbv
Copy link
Contributor

lucbv commented Feb 24, 2025

For reference here is the output on our local testing machine:

[----------] Global test environment tear-down
[==========] 22 tests from 1 test suite ran. (2057 ms total)
[  PASSED  ] 19 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] sycl_test.common_AlignPtrTo_0
[  FAILED  ] sycl_test.common_AlignPtrTo_2
[  FAILED  ] sycl_test.common_AlignPtrTo_3

 3 FAILED TESTS

@masterleinad
Copy link
Contributor Author

@cwpearson Do we really care about this test? It's my understanding that it check for an implementation that isn't used in Kokkos Kernels anyway. Do you have any plans to use a different implementation if this works now in newer oneAPI compilers?

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
@masterleinad masterleinad force-pushed the fix_sycl_test_common_alignptrto branch from 048f2bc to 8479c62 Compare February 25, 2025 19:47
@lucbv
Copy link
Contributor

lucbv commented Feb 26, 2025

Still failing on the same test but with the serial backend, please revert back to the original logic, just add the condition: KOKKOS_COMPILER_INTEL_LLVM < 20250000

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
@masterleinad
Copy link
Contributor Author

Still failing on the same test but with the serial backend, please revert back to the original logic, just add the condition: KOKKOS_COMPILER_INTEL_LLVM < 20250000

Here you go!

Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay that looks good and was tested with oneapi 2023 and 2025

@lucbv lucbv added AT2-CI-APPROVAL Approve CI to run at SNL and removed AT2-CI-APPROVAL Approve CI to run at SNL labels Feb 26, 2025
@lucbv lucbv merged commit d1e6670 into kokkos:develop Feb 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-CI-APPROVAL Approve CI to run at SNL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants