c++17: add [[fallthrough]] attribute

kokkos · May 14, 2024 · e1f06ec · e1f06ec
1 parent a5794bb
commit e1f06ec
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/graph/impl/KokkosGraph_Distance2Color_impl.hpp b/graph/impl/KokkosGraph_Distance2Color_impl.hpp
@@ -157,7 +157,7 @@ class GraphColorDistance2 {
       colors_out = color_view_type("Graph Colors", this->nr);
     }
     switch (this->gc_handle->get_coloring_algo_type()) {
-      case COLORING_D2_VB_BIT_EF: using_edge_filtering = true;
+      case COLORING_D2_VB_BIT_EF: using_edge_filtering = true; [[fallthrough]];
       case COLORING_D2_VB_BIT:
       case COLORING_D2_VB: compute_d2_coloring_vb(colors_out); break;
       case COLORING_D2_NB_BIT: compute_d2_coloring_nb(colors_out); break;

diff --git a/graph/src/KokkosGraph_Triangle.hpp b/graph/src/KokkosGraph_Triangle.hpp
@@ -164,10 +164,7 @@ void triangle_generic(KernelHandle *handle, typename KernelHandle::nnz_lno_t m,
   spgemmHandleType *sh = handle->get_spgemm_handle();
   switch (sh->get_algorithm_type()) {
     // case SPGEMM_KK_TRIANGLE_LL:
-    case SPGEMM_KK_TRIANGLE_AI:
-    case SPGEMM_KK_TRIANGLE_IA:
-    case SPGEMM_KK_TRIANGLE_IA_UNION:
-    default: {
+    case SPGEMM_KK_TRIANGLE_AI case SPGEMM_KK_TRIANGLE_IA case SPGEMM_KK_TRIANGLE_IA_UNION default: {
       KokkosSparse::Impl::KokkosSPGEMM<
           KernelHandle, alno_row_view_t_, alno_nnz_view_t_,
           typename KernelHandle::in_scalar_nnz_view_t, blno_row_view_t_,

diff --git a/perf_test/sparse/KokkosSparse_sptrsv.cpp b/perf_test/sparse/KokkosSparse_sptrsv.cpp
@@ -279,6 +279,7 @@ int test_sptrsv_perf(std::vector<int> tests, const std::string &lfilename,
 #else
           std::cout << "CUSPARSE not enabled: Fall through to defaults"
                     << std::endl;
+          [[fallthrough]];
 #endif
         default:
           kh.create_sptrsv_handle(SPTRSVAlgorithm::SEQLVLSCHD_TP1, nrows,
@@ -681,6 +682,7 @@ int test_sptrsv_perf(std::vector<int> tests, const std::string &lfilename,
 #else
           std::cout << "CUSPARSE not enabled: Fall through to defaults"
                     << std::endl;
+          [[fallthrough]];
 #endif
         default:
           kh.create_sptrsv_handle(SPTRSVAlgorithm::SEQLVLSCHD_TP1, nrows,

diff --git a/sparse/impl/KokkosSparse_spgemm_impl_memaccess.hpp b/sparse/impl/KokkosSparse_spgemm_impl_memaccess.hpp
@@ -663,7 +663,7 @@ void KokkosSPGEMM<HandleType, a_row_view_t_, a_lno_nnz_view_t_,
                               cache_1_line_count);
                     }
                   } break;
-                  case 2: hyper_thread_ind = 1;
+                  case 2: hyper_thread_ind = 1; [[fallthrough]];
                   case 1: {
                     nnz_lno_t result_col_ind =
                         result_col + (hyper_thread_ind - 1) * b_col_cnt;