-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce cmake-format in CI #229
Conversation
in kokkos/kokkos we use |
That makes sense. Maybe it is better to apply the same format as Kokkos for the consistency of the ecosystem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
Consider adding a small explanation on how to apply these tools for contributors ? |
If we do we should do this on Kokkos, too |
Actually, I am considering to add a developers note to the documentation in another PR. cmake-format will be explained there as well as clang-format.
I think it would be useful for kokkos |
8f09c87
to
6f1f0d6
Compare
Ok then it can wait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me
@tpadioleau Thank you for approval. I will merge this. |
This PR aims at introducing CMake format check with
gersemicmake-format.