Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cmake-format in CI #229

Merged
merged 6 commits into from
Feb 22, 2025

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Feb 20, 2025

This PR aims at introducing CMake format check with gersemi cmake-format.

@JBludau
Copy link

JBludau commented Feb 20, 2025

in kokkos/kokkos we use cmake-format and also have an action to check it. If you want less maintenance burden you could think about copying our scripts

@yasahi-hpc
Copy link
Collaborator Author

That makes sense. Maybe it is better to apply the same format as Kokkos for the consistency of the ecosystem.

@yasahi-hpc yasahi-hpc changed the title Introduce gersemi for CMake formatting Introduce cmake-format in CI Feb 21, 2025
tpadioleau
tpadioleau previously approved these changes Feb 21, 2025
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@tpadioleau
Copy link
Member

Consider adding a small explanation on how to apply these tools for contributors ?

@JBludau
Copy link

JBludau commented Feb 21, 2025

Consider adding a small explanation on how to apply these tools for contributors ?

If we do we should do this on Kokkos, too

@yasahi-hpc
Copy link
Collaborator Author

Consider adding a small explanation on how to apply these tools for contributors ?

Actually, I am considering to add a developers note to the documentation in another PR. cmake-format will be explained there as well as clang-format.

If we do we should do this on Kokkos, too

I think it would be useful for kokkos

@yasahi-hpc yasahi-hpc force-pushed the introduce-cmake-format branch from 8f09c87 to 6f1f0d6 Compare February 22, 2025 13:23
@tpadioleau
Copy link
Member

Actually, I am considering to add a developers note to the documentation in another PR. cmake-format will be explained there as well as clang-format.

Ok then it can wait

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@yasahi-hpc
Copy link
Collaborator Author

@tpadioleau Thank you for approval. I will merge this.
I will make a PR for docs next Monday.

@yasahi-hpc yasahi-hpc merged commit 77161f5 into kokkos:main Feb 22, 2025
22 checks passed
@yasahi-hpc yasahi-hpc deleted the introduce-cmake-format branch February 22, 2025 19:19
@yasahi-hpc yasahi-hpc mentioned this pull request Feb 25, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants