Major overhaul of build instructions and reorganizing sections #631
+585
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
force-pushed
the
overhaul_build_instructions_and_general_organization
branch
from
5ba2eb1 to
1fe722b
Compare
crtrott
reviewed
Feb 18, 2025
|
|
||
| * ``-DCMAKE_CXX_COMPILER=<compiler>``: Specifies the full path to the C++ | ||
| compiler. For example, use ``hipcc`` for AMD GPUs, ``icpx`` for Intel GPUs, | ||
| or ``g++`` or ``clang++`` for CPUs. |
There was a problem hiding this comment.
We may wanna say something about CUDA here. There are so many examples, but NVIDIA is missing. A user could assume that simply means he should set NVCC as the CMAKE_CXX_COMPILER since one uses the vendor compilers for the AMD and Intel GPUs.
There was a problem hiding this comment.
Let's improve in a follow up
crtrott
reviewed
Feb 18, 2025
crtrott
approved these changes
Feb 18, 2025
Co-authored-by: Christian Trott <crtrott@sandia.gov>
dalg24
deleted the
overhaul_build_instructions_and_general_organization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.