Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DualView::view_[host|device] #628

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

masterleinad
Copy link
Contributor

Related to kokkos/kokkos#7716.

@masterleinad masterleinad force-pushed the dual_view_update_raw_access branch from 763b502 to 22fc801 Compare February 18, 2025 15:10
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some wording suggestions

@@ -124,11 +124,11 @@ Description

.. cppkokkos:member:: t_dev d_view

The view instance on the *device*
The view instance on the *device*, public access deprecated from Kokkos 4.6 on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The view instance on the *device*, public access deprecated from Kokkos 4.6 on.
The view instance on the *device*, public access deprecated in Kokkos 4.6.


.. cppkokkos:member:: t_host h_view

The view instance on the *host*
The view instance on the *host*, public access deprecated from Kokkos 4.6 on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The view instance on the *host*, public access deprecated from Kokkos 4.6 on.
The view instance on the *host*, public access deprecated in Kokkos 4.6.

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: JBludau <104908666+JBludau@users.noreply.github.com>
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the content.

@masterleinad masterleinad merged commit 59d2cf1 into kokkos:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants