-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document DualView::view_[host|device] #628
Document DualView::view_[host|device] #628
Conversation
763b502
to
22fc801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some wording suggestions
@@ -124,11 +124,11 @@ Description | |||
|
|||
.. cppkokkos:member:: t_dev d_view | |||
|
|||
The view instance on the *device* | |||
The view instance on the *device*, public access deprecated from Kokkos 4.6 on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The view instance on the *device*, public access deprecated from Kokkos 4.6 on. | |
The view instance on the *device*, public access deprecated in Kokkos 4.6. |
|
||
.. cppkokkos:member:: t_host h_view | ||
|
||
The view instance on the *host* | ||
The view instance on the *host*, public access deprecated from Kokkos 4.6 on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The view instance on the *host*, public access deprecated from Kokkos 4.6 on. | |
The view instance on the *host*, public access deprecated in Kokkos 4.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: JBludau <104908666+JBludau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with the content.
Related to kokkos/kokkos#7716.