Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting the CPU arch #602

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Formatting the CPU arch #602

merged 15 commits into from
Nov 25, 2024

Conversation

JBludau
Copy link
Contributor

@JBludau JBludau commented Nov 12, 2024

@dalg24 wanted a nicer table and the archs sorted by recency.
The supercomputers are added as examples but might help people finding what they need.

It adds a new dependency on linuxdoc and imghdr (secondary from linuxdoc but somehow not found correctly in pip)

@JBludau JBludau requested a review from dalg24 November 12, 2024 21:28
@JBludau JBludau self-assigned this Nov 12, 2024
@JBludau
Copy link
Contributor Author

JBludau commented Nov 12, 2024

it renders like this:
Screenshot 2024-11-12 at 4 30 29 PM

@JBludau
Copy link
Contributor Author

JBludau commented Nov 12, 2024

looks like this now (in dark mode)
Screenshot 2024-11-12 at 6 26 02 PM

@JBludau JBludau mentioned this pull request Nov 13, 2024
@JBludau
Copy link
Contributor Author

JBludau commented Nov 18, 2024

Instead of using the linuxdoc plugin we can also just create individual tables for each vendor ...
renders like this
Screenshot 2024-11-18 at 9 49 15 AM

JBludau and others added 4 commits November 18, 2024 13:44
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@JBludau JBludau requested a review from dalg24 November 20, 2024 15:49
@dalg24 dalg24 merged commit db01e6b into kokkos:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants