Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing macros #598

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add missing macros #598

merged 2 commits into from
Nov 5, 2024

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Nov 5, 2024

No description provided.

dalg24
dalg24 reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but so you know I wanted to move away to these list and have blanket wording saying that there is one macro for each configure time option.
The main one that would need to be covered is KOKKOS_ARCH_AMD_GPU

docs/source/API/core/Macros.rst Outdated
+-----------------------------------+-----------------------------------------------------------------------------------+
| ``KOKKOS_ARCH_AMD_GFX1103`` | Optimize for AMD Phoenix APU (GPU) |
+-----------------------------------+-----------------------------------------------------------------------------------+
| ``KOKKOS_ARCH_AMD_GPU`` | String of the architecture flag for AMD GPU |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding "(e.g. "gfx90A" when targeting a MI250X accelerator)"

masterleinad
masterleinad approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@dalg24 dalg24 merged commit dc409e9 into kokkos:main Nov 5, 2024
2 checks passed
@Rombur Rombur deleted the macros branch November 6, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rombur @dalg24 @masterleinad