Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for two AMD APUs #597

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add documentation for two AMD APUs #597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f198fe
Add documentation for two AMD APUs
Rombur Nov 5, 2024
c3423b8
Better define Phoenix APU
Rombur Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docs/source/keywords.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,10 +575,15 @@ Kokkos will attempt to autodetect the architecture flag at configuration time.
- Models
- Notes

* * ``Kokkos_ARCH_AMD_GFX942_APU``
* GFX942
* MI300A
* (since Kokkos 4.5)

* * ``Kokkos_ARCH_AMD_GFX942``
* GFX942
* MI300A, MI300X
* (since Kokkos 4.2)
* (since Kokkos 4.2, since Kokkos 4.5 this should only be used for MI300X)

* * ``Kokkos_ARCH_AMD_GFX940``
* GFX940
Expand All @@ -599,6 +604,11 @@ Kokkos will attempt to autodetect the architecture flag at configuration time.
* GFX906
* MI50, MI60
* (since Kokkos 4.2)

* * ``Kokkos_ARCH_AMD_GFX1103``
* GFX1103
* Phoenix APU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, "Phoenix" is the codename for the microarchitecture whereas this column says "Models".
Should we list a couple popular models, something like "Phoenix APUs (e.g. MODEL-1, MODEL-2, etc.)"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added something

* (since Kokkos 4.5)

* * ``Kokkos_ARCH_AMD_GFX1100``
* GFX1100
Expand Down
Loading