Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniqueToken.md: API documentation for UniqueToken.md #179

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/API/core/ParallelDispatch.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ The following parallel pattern tags are used to call the correct overload for te
./parallel-dispatch/parallel_reduce
./parallel-dispatch/parallel_scan
./parallel-dispatch/fence
./parallel-dispatch/UniqueToken.rst
./parallel-dispatch/ParallelForTag
./parallel-dispatch/ParallelReduceTag
./parallel-dispatch/ParallelScanTag
103 changes: 103 additions & 0 deletions docs/source/API/core/parallel-dispatch/UniqueToken.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
``UniqueToken``
===============

Header File: ``Kokkos_Core.hpp``


Description
------------

``UniqueToken`` is a portable way to acquire a unique ID for a thread (``thread-id`` is not portable across execution environments). The unique ID is scoped by the ``UniqueTokenScope`` template parameter (defaults to ``Instance``, but can be set to ``Global``).

Interface
---------

.. code-block:: cpp

template <class ExecutionSpace = DefaultExecutionSpace, UniqueTokenScope = UniqueTokenScope::Instance> UniqueToken



Parameters
-----------

* ``ExecutionSpace``: See `Execution Spaces <../execution_spaces.html>`_

* ``UniqueTokenScope``: defaults to ``Instance``, and every instance is independent of another. In contrast, ``Global`` uses one set of unique IDs for all instances.

.. note::
In a parallel region, before the main computation, a pool of ``UniqueToken`` (integer) ID is generated, and each ID is released following iteration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each ID is released following iteration.

I don't quite understand what this means.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess she meant to say that the token is released at the end of the iteration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked for clarity.


.. warning::
``UniqueToken <ExecutionSpace> token`` *can* be called inside a parallel region, *but* must be released at the end of *each* iteration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be saying "work item" instead of "iteration"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either formulation is fine : " ... each iterate" or " ... each work item"




Constructors
-------------

.. code-block:: cpp

UniqueToken(size_type max_size, ExecutionSpace execution_space = ExecutionSpace())
// Scope is instance

.. code-block:: cpp

UniqueToken(size_type max_size, ExecutionSpace execution_space = ExecutionSpace()) requires(TokenScope == Global);
// Scope is global
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not following what is the difference between the two.
Should that be interpreted as, regardless of whether TokenScope is instance or global, the constructor takes an integer argument and optionally an execution space trailing argument that defaults to the default exec space instance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think are right, the constructor that takes a max_size will instantiate UniqueToken<ExecutionSpace,UniqueTokenScope::Instance>.
The one with only the ExecutionSpace as argument does not restrict the scope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes -- the main distinction is scope (instance or global).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. code-block:: cpp
UniqueToken(size_type max_size, ExecutionSpace execution_space = ExecutionSpace())
// Scope is instance
.. code-block:: cpp
UniqueToken(size_type max_size, ExecutionSpace execution_space = ExecutionSpace()) requires(TokenScope == Global);
// Scope is global
.. code-block:: cpp
UniqueToken(size_type max_size, ExecutionSpace execution_space = ExecutionSpace{})
// Scope is instance
UniqueToken(ExecutionSpace execution_space = ExecutionSpace{})
// Scope can be instance or global



Public Member Functions
------------------------

.. code-block:: cpp

UniqueToken(size_type max_size, ExecutionSpace execution_space=ExecutionSpace())

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. code-block:: cpp
UniqueToken(size_type max_size, ExecutionSpace execution_space=ExecutionSpace())

presumably a copy pasta error

.. code-block:: cpp

size_type size()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we forget to define size_type?

// Returns the size of the token pool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dedicated syntax for return

Suggested change
// Returns the size of the token pool
:returns: the size of the token pool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:return: doesn't work (as a Sphinx directive) with .. code-block:: cpp or .. cpp:function::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@ajpowelsnl ajpowelsnl Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, code-block:: cpp (vs. cpp:function::) is being used (i.e., cpp:function requires a conventional function signature (vs. method on a class).


.. code-block:: cpp

size_type acquire()
// Returns the token for the executing tread

.. code-block:: cpp

void release(size_type idx)
// Releases the passed token

.. warning::
Acquired tokens *must* be released at the end of the parallel region in which they were acquired




Examples
---------

.. code-block:: cpp

// UniqueToken on an Execution Space Instance
UniqueToken < ExecutionSpace > token ;
int number_of_uniqe_ids = token.size ();
RandomGenPool pool ( number_of_unique_ids , seed );

parallel_for ("L", N, KOKKOS_LAMBDA ( int i) {
auto id = token.acquire ();
RandomGen gen = pool (id);
// Computation Body
token.release (id);
});

// Submitting concurrent kernels to (e.g., CUDA) streams

void foo () {
UniqueToken < ExecSpace , UniqueTokenScope :: Global > token_foo ;
parallel_for ("L", RangePolicy < ExecSpace >( stream1 ,0,N), functor_a ( token_foo ));}

void bar () {
UniqueToken < ExecSpace , UniqueTokenScope :: Global > token_bar ;
parallel_for ("L", RangePolicy < ExecSpace >( stream2,0,N), functor_b ( token_bar ));}
Loading