[16.0][IMP] add button Create Shipping Label #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilshamerlinck
suggested changes
Jun 21, 2023
| @@ -236,3 +236,8 @@ def generate_postlogistics_shipping_labels(self, package_ids=None): | |||
| """Add label generation for PostLogistics""" | |||
| self.ensure_one() | |||
| return self._generate_postlogistics_label(package_ids=package_ids) | |||
|
|
|||
| def action_generate_carrier_label(self): | |||
| for pick in self: | |||
There was a problem hiding this comment.
for the sake of factorization, why not call postlogistics_send_shipping here?
There was a problem hiding this comment.
hello @nilshamerlinck, this PR has been updated.
| name="action_generate_carrier_label" | ||
| help="Create Shipping Label 🚚" | ||
| attrs="{'invisible': [('state', '!=', 'done')]}" | ||
| string="Shipping Label 🚚" |
There was a problem hiding this comment.
Suggested change
| string="Shipping Label 🚚" | |
| string="Create Shipping Label 🚚" |
There was a problem hiding this comment.
hello @nilshamerlinck, this PR has been updated.
khoivo1601
force-pushed
the
16.0-add-button-create-shipping-method
branch
from
59054f6 to
4529665
Compare
nilshamerlinck
approved these changes
Jun 21, 2023
khoivo1601
force-pushed
the
16.0-add-button-create-shipping-method
branch
from
4529665 to
7b8c474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Shipping Labelback indelivery_postlogisticsValidate stock.pickingorCreate Shipping Label--> generate and add an attachment