[IMP] base_delivery_carrier_files: pass pickings to _write_file

_write_file was designed to be inheritable to implement other file storages,
but without access to the pickings it is not possible to implement attachment
or binary fields storage.

Author: StefanRijnhart

base_delivery_carrier_files/models/delivery_carrier_file.py

@@ -29,7 +29,7 @@ def get_write_mode_selection(self):
         """
         return [("disk", "Disk")]
 
-    def _write_file(self, filename, file_content):
+    def _write_file(self, filename, file_content, pickings):
         """
         Method responsible of writing the file, on the filesystem or
         by inheriting the module, in the document module as instance
@@ -38,6 +38,7 @@ def _write_file(self, filename, file_content):
                                            (configuration)
         :param tuple filename: name of the file to write
         :param tuple file_content: content of the file to write
+        :param recordset pickings: pickings to which the file applies
         :return: True if write is successful
         """
         for carrier_file in self:
@@ -75,20 +76,21 @@ def _generate_files(self, picking_ids):
 
             for f in files:
                 filename, file_content, picking_ids = f
+                pickings = self.env["stock.picking"].browse(picking_ids or [])
                 # we pass the errors because the files can still be
                 # generated manually
                 # at first I would like to open a new cursor and
                 # commit the write after each file created
                 # but I encountered lock because the picking
                 # was already modified in the current transaction
                 try:
-                    if this._write_file(filename, file_content):
+                    if this._write_file(filename, file_content, pickings):
                         picking_obj.browse(picking_ids).write(
                             {"carrier_file_generated": True}
                         )
                 except Exception as e:
                     log.exception(
-                        "Could not create the picking file " "for pickings %s: %s",
+                        "Could not create the picking file for pickings %s: %s",
                         picking_ids,
                         e,
                     )

base_delivery_carrier_files/tests/test_base_delivery_carrier_files.py

@@ -19,7 +19,7 @@ def setUp(self):
                 "auto_export": True,
                 "group_pickings": False,
                 "write_mode": "disk",
-                "export_path": "/tmp",
+                "export_path": tempfile.gettempdir(),
             }
         )
 
@@ -30,7 +30,7 @@ def setUp(self):
                 "auto_export": False,
                 "group_pickings": True,
                 "write_mode": "disk",
-                "export_path": "/tmp",
+                "export_path": tempfile.gettempdir(),
             }
         )
 
@@ -74,12 +74,6 @@ def setUp(self):
 
     def test_carrier_file_generation(self):
         """ Test carrier file generation """
-        # I configure the carrier file configuration
-        # to write to the root document directory.
-        self.carrier_file.write(
-            {"export_path": tempfile.gettempdir(), "write_mode": "disk"}
-        )
-
         # I confirm outgoing shipment of 130 kgm Ice-cream.
         picking = self.env["stock.picking"].create(
             {
@@ -125,12 +119,6 @@ def test_carrier_file_generation(self):
 
     def test_manual_carrier_file_generation(self):
         """ Test manual carrier file generation """
-        # I configure the carrier file configuration
-        # to write to the root document directory.
-        self.carrier_file_manual.write(
-            {"export_path": tempfile.gettempdir(), "write_mode": "disk"}
-        )
-
         # I confirm outgoing shipment of 130 kgm Ice-cream.
         picking = self.env["stock.picking"].create(
             {