[MIG] base_delivery_carrier_files: Migration to 14.0

Author: StefanRijnhart

base_delivery_carrier_files/__manifest__.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     "name": "Base Delivery Carrier Files",
-    "version": "12.0.1.0.1",
+    "version": "14.0.1.0.0",
     "category": "Generic Modules/Warehouse",
     "author": "Camptocamp,Odoo Community Association (OCA)",
     "license": "AGPL-3",

base_delivery_carrier_files/models/delivery_carrier_file.py

@@ -29,7 +29,6 @@ def get_write_mode_selection(self):
         """
         return [("disk", "Disk")]
 
-    @api.multi
     def _write_file(self, filename, file_content):
         """
         Method responsible of writing the file, on the filesystem or

base_delivery_carrier_files/models/stock_move.py

@@ -2,22 +2,17 @@
 # Author: Guewen Baconnier
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, models
+from odoo import models
 
 
 class StockMove(models.Model):
     _inherit = "stock.move"
 
-    @api.multi
     def write(self, values):
         write_result = super(StockMove, self).write(values)
-        if values.get("state") and values["state"] == "done":
-            picking_ids = list(map(lambda p: p.id, self.mapped("picking_id")))
-            done_pickings = self.env["stock.picking"].search(
-                [
-                    ("id", "in", picking_ids),
-                    ("state", "=", "done"),
-                ]
+        if values.get("state") == "done":
+            done_pickings = self.mapped("picking_id").filtered(
+                lambda sp: sp.state == "done"
             )
             if done_pickings:
                 done_pickings.generate_carrier_files()

base_delivery_carrier_files/models/stock_picking.py

@@ -2,13 +2,12 @@
 # Author: Guewen Baconnier
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import fields, models
 
 
 class StockPicking(models.Model):
     _inherit = "stock.picking"
 
-    @api.multi
     def generate_carrier_files(self, auto=True, recreate=False):
         """
         Generates all the files for a list of pickings according to
@@ -48,9 +47,8 @@ def generate_carrier_files(self, auto=True, recreate=False):
             carrier_file.generate_files(carrier_file_ids[carrier_file.id])
         return True
 
-    @api.multi
-    def action_done(self):
-        result = super(StockPicking, self).action_done()
+    def _action_done(self):
+        result = super(StockPicking, self)._action_done()
         self.generate_carrier_files(auto=True)
         return result
 

base_delivery_carrier_files/readme/CONTRIBUTORS.rst

@@ -1,3 +1,4 @@
 * Guewen Baconnier <guewen.baconnier@camptocamp.com>
 * Tom Blauwendraat <tom@sunflowerweb.nl>
 * Marc Poch <mpoch@planetatic.com>
+* Stefan Rijnhart <stefan@opener.amsterdam>

base_delivery_carrier_files/security/ir.model.access.csv

@@ -2,3 +2,4 @@ id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_delivery_carrier_file,delivery.carrier.file,model_delivery_carrier_file,sales_team.group_sale_salesman,1,0,0,0
 access_delivery_carrier_file_manager,delivery.carrier.file manager,model_delivery_carrier_file,sales_team.group_sale_manager,1,1,1,1
 access_delivery_carrier_file_partner_manager,delivery.carrier.file partner_manager,model_delivery_carrier_file,base.group_partner_manager,1,0,0,0
+access_delivery_carrier_file_generate,delivery.carrier.file.generate,model_delivery_carrier_file_generate,sales_team.group_sale_salesman,1,1,1,1

base_delivery_carrier_files/tests/test_base_delivery_carrier_files.py

@@ -70,13 +70,7 @@ def setUp(self):
             }
         )
 
-        self.picking_type = self.env["stock.picking.type"].create(
-            {
-                "name": "Outgoing Ice Cream",
-                "code": "outgoing",
-                "sequence_id": self.env.ref("stock.sequence_mrp_op").id,
-            }
-        )
+        self.picking_type = self.env.ref("stock.warehouse0").out_type_id
 
     def test_carrier_file_generation(self):
         """ Test carrier file generation """
@@ -114,8 +108,11 @@ def test_carrier_file_generation(self):
         # I check outgoing shipment after stock availablity in refrigerator.
         picking.action_assign()
 
-        # I deliver outgoing shipment.
-        picking.action_done()
+        # I deliver the outgoing shipment.
+        action = picking.button_validate()
+        self.env[action["res_model"]].with_context(action["context"]).create(
+            {}
+        ).process()
 
         # I check shipment details after shipment
         # The carrier file must have been generated.
@@ -163,8 +160,11 @@ def test_manual_carrier_file_generation(self):
         # I check outgoing shipment after stock availablity in refrigerator.
         picking.action_assign()
 
-        # I deliver outgoing shipment.
-        picking.action_done()
+        # I deliver the outgoing shipment.
+        action = picking.button_validate()
+        self.env[action["res_model"]].with_context(action["context"]).create(
+            {}
+        ).process()
 
         # I check shipment details after shipment
         # The carrier file must NOT have been generated.

base_delivery_carrier_files/views/carrier_file_view.xml

@@ -41,7 +41,6 @@
         <field name="name">Carrier File</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">delivery.carrier.file</field>
-        <field name="view_type">form</field>
         <field name="view_mode">tree,form</field>
     </record>
 

base_delivery_carrier_files/wizards/generate_carrier_files.py

@@ -17,7 +17,6 @@ def _get_pickings(self):
         if context.get("active_model") == "stock.picking" and context.get("active_ids"):
             return self.env["stock.picking"].browse(context["active_ids"])
 
-    @api.multi
     def action_generate(self):
         """
         Call the creation of the delivery carrier files
@@ -31,7 +30,6 @@ def action_generate(self):
         "stock.picking",
         string="Delivery Orders",
         default=_get_pickings,
-        oldname="picking_ids",
     )
     recreate = fields.Boolean(
         "Recreate files",

base_delivery_carrier_files/wizards/generate_carrier_files_view.xml

@@ -47,7 +47,6 @@
         <field name="name">Generate Carrier Files</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">delivery.carrier.file.generate</field>
-        <field name="view_type">form</field>
         <field name="view_mode">form</field>
         <field name="view_id" ref="view_delivery_carrier_file_generate" />
         <field name="groups_id" eval="[(6, 0, [ref('stock.group_stock_manager')])]" />