Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct dist values. #24

Closed
wants to merge 3 commits into from
Closed

Ensure correct dist values. #24

wants to merge 3 commits into from

Conversation

vlulla
Copy link

@vlulla vlulla commented Jul 19, 2020

Validate dist name at data definition instead of waiting until data generation.

@assignUser
Copy link
Collaborator

Thank you for your contribution! We are currently working on a complete overhaul of the formula and definition system ( #22 #18 #15) that also addresses the issue you raised here. Consequently we are not going to merge your pr but we appreciate your input! 😃

@assignUser assignUser closed this Aug 6, 2020
@vlulla vlulla deleted the validate-distnames branch August 6, 2020 23:31
@assignUser
Copy link
Collaborator

@vlulla as of 0.2.1 this should now happen as you requested

@vlulla
Copy link
Author

vlulla commented Oct 8, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlulla @assignUser