Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and enhance Kedro VSCode extension documentation #4538

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jitu5
Copy link

@jitu5 jitu5 commented Mar 3, 2025

Description

Resolves #4458

This pull request includes several changes to the documentation, primarily focusing on improving the organization and clarity of the setup guides for VS Code.

Development notes

New content for VS Code extension:

  • docs/source/visual_studio_code_extension/set_up_vscode.md: Added detailed instructions on setting a custom Kedro project path, including using the command palette, VS Code settings UI, and multi-root workspace integration. This file was renamed from docs/source/development/set_up_vscode.md.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

jitu5 and others added 7 commits March 3, 2025 12:25
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
@jitu5 jitu5 changed the title Moving VSCode docs to root Update and enhance Kedro VSCode extension documentation Mar 6, 2025
jitu5 added 4 commits March 6, 2025 15:51
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
@jitu5 jitu5 self-assigned this Mar 6, 2025
@jitu5 jitu5 added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Mar 6, 2025
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
@jitu5 jitu5 marked this pull request as ready for review March 6, 2025 18:15
@astrojuanlu
Copy link
Member

Does this clash with #4542 ?

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jitu5 ! Content-wise, the diff here looks good.

Having said that, I'm now reflecting on what I wrote in #4458 and the investigation we did for kedro-org/vscode-kedro#151, and I think it's worth making some changes to the Information Architecture...

What about something like this?

image

Hence

This is what I did locally to create the screenshot:

diff --git a/docs/source/index.rst b/docs/source/index.rst
index 501028cf..6d264a16 100644
--- a/docs/source/index.rst
+++ b/docs/source/index.rst
@@ -91,6 +91,16 @@ Welcome to Kedro's award-winning documentation!
    integrations/kedro_dvc_versioning.md
    integrations/deltalake_versioning.md
 
+.. toctree::
+   :maxdepth: 2
+   :caption: Development
+
+   development/set_up_vscode
+   development/set_up_pycharm
+   development/debugging
+   development/automated_testing
+   development/linting
+
 .. toctree::
    :maxdepth: 2
    :caption: Advanced usage
@@ -99,20 +109,19 @@ Welcome to Kedro's award-winning documentation!
    extend_kedro/index.md
    hooks/index.md
    logging/index.md
-   development/index.md
    deployment/index.md
 
 .. toctree::
    :maxdepth: 2
-   :caption: Kedro VS Code Extension
+   :caption: Contribute to Kedro
 
-   visual_studio_code_extension/set_up_vscode.md
+   contribution/index.md
 
 .. toctree::
    :maxdepth: 2
-   :caption: Contribute to Kedro
+   :caption: CLI reference
 
-   contribution/index.md
+   development/commands_reference.md
 
 API documentation
 =================

Comment on lines +106 to +108
- Your Kedro project is not at the root of your workspace
- You want to work with a Kedro project that is outside your current workspace
- You have multiple Kedro projects and want to switch between them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment on lines +111 to +113
### Ways to set a custom path for Kedro project:

#### Using the command palette
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Suggested change
### Ways to set a custom path for Kedro project:
#### Using the command palette
### Set up a custom path using the command palette

(and same with the other H4 below)

@astrojuanlu
Copy link
Member

Other comments, not entirely related to this PR:


1. Ensure the path points to a valid Kedro project (containing `pyproject.toml` with Kedro dependencies)
2. Check that the path is an absolute path, not a relative one
3. Reload VS Code if the changes don’t take effect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any quick way to check the extension has picked up the new project path ? Like some kind of logger or console output which can help users confirm of the change ?

@astrojuanlu astrojuanlu requested a review from iamelijahko March 6, 2025 19:45
@astrojuanlu
Copy link
Member

Also adding @iamelijahko as reviewer, since this is somehow connected to the onboarding flow

@ravi-kumar-pilla ravi-kumar-pilla self-requested a review March 6, 2025 19:55
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jitu5 , The docs look great. I echo with @astrojuanlu suggestion on having a development section. I left a minor comment but everything else looks good. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation about VS Code extension
3 participants