feat/remove-viz-tool

[Huongg]

Description

As part of kedro-org/kedro-starters#263, we need to remove the Viz tool since it is automatically included when a user runs kedro new.

This PR ensures there are no remaining references to the Viz tool in the starters. If a user includes viz or the number 7 in their setup, they will see an error message stating:
"Kedro Viz is automatically included in the project. Please remove 'viz' from your setup."
or
"Kedro Viz is automatically included in the project. Please remove 7 from your setup."

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

• Read the contributing guidelines
• Signed off each commit with a Developer Certificate of Origin (DCO)
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the RELEASE.md file
• Added tests to cover my changes
• Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

[ankatiyar]

Was just manually testing this branch and realised that you'd also need to update the prompt here: https://github.com/kedro-org/kedro/blob/main/kedro/templates/project/prompts.yml

[rashidakanchwala]

Hey,

I tested this, and it worked well—Kedro-Viz didn’t appear as an option, which was great. However, after selecting option 7, it first asked if I wanted an example pipeline before informing me that the project couldn't be created because option 7 didn’t exist. Ideally, selecting option 7 should immediately throw an error instead of proceeding further.

If we could surface this error earlier, that would improve the experience. Otherwise, everything else was fine.

[merelcht]

If we could surface this error earlier, that would improve the experience. Otherwise, everything else was fine.

Agreed on this, but that has always been the behaviour so not really part of this task. Let's create a separate ticket for that.

[rashidakanchwala]

ok since the other issue will be tackled in a seperate ticket. This looks good to me. Thanks @Huongg.

Also, can we create the other issue so we dont' forget.

[merelcht]

LGTM, just don't forget to add this to the release notes ✍️

[ElenaKhaustova]

I've tested it and it works well as described.

One thing I find confusing is that we process 7 different from other non-valid selections. Is there a specific reason for that?

For example, if selecting 8 we get:

'8' is not a valid selection.
Please select from the available tools: 1, 2, 3, 4, 5, 6.

Should we process 7 differently at all? And if yes, maybe it makes sense extending the original message rather than fully replacing it, so it was clear that the nature of the problem is non-valid selection?

But if it was done intentionally - feel free to merge 🙂

[Huongg]

I've tested it and it works well as described.

One thing I find confusing is that we process 7 different from other non-valid selections. Is there a specific reason for that?

For example, if selecting 8 we get:

'8' is not a valid selection.
Please select from the available tools: 1, 2, 3, 4, 5, 6.

Should we process 7 differently at all? And if yes, maybe it makes sense extending the original message rather than fully replacing it, so it was clear that the nature of the problem is non-valid selection?

But if it was done intentionally - feel free to merge 🙂

hey @ElenaKhaustova thanks for reviewing the PR. The reason we see a different error for number 7 is that it was originally associated with Kedro-Viz. However, since we've now removed 7 and kedro-viz from the tools, we want to ensure that if a user includes it in their tool selection, it indicates that Kedro-Viz is automatically included when they run kedro new

[ElenaKhaustova]

I've tested it and it works well as described.
One thing I find confusing is that we process 7 different from other non-valid selections. Is there a specific reason for that?
For example, if selecting 8 we get:

'8' is not a valid selection.
Please select from the available tools: 1, 2, 3, 4, 5, 6.

Should we process 7 differently at all? And if yes, maybe it makes sense extending the original message rather than fully replacing it, so it was clear that the nature of the problem is non-valid selection?
But if it was done intentionally - feel free to merge 🙂

hey @ElenaKhaustova thanks for reviewing the PR. The reason we see a different error for number 7 is that it was originally associated with Kedro-Viz. However, since we've now removed 7 and kedro-viz from the tools, we want to ensure that if a user includes it in their tool selection, it indicates that Kedro-Viz is automatically included when they run kedro new

I see, thanks for explaining. Then maybe we can have a message like that:

`7` is not a valid selection.
Please select from the available tools: 1, 2, 3, 4, 5, 6.
Kedro Viz is automatically included in the project. Please remove `7` from your tool selection.

[ElenaKhaustova]

Approving with a suggestion left, thank you @Huongg

[ankatiyar]

Maybe this function needs to be renamed too