Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use entrypoint to automatically pip-install mounted edx-platform #24

Closed
wants to merge 1 commit into from

Conversation

kdmccormick
Copy link
Owner

@kdmccormick kdmccormick commented Jan 11, 2023

Implements "Option A" from openedx-unsupported/wg-developer-experience#152, specifically:

A. Entrypoint script:

  • Write an entrypoint script (we'll call it set-up-and-run). It should first do the ensure-setup thing. Then, it should run the arguments passed to it as a shell command.
    • For example: set-up-and-run ./manage.py lms runserver ... would create the egg-info if necessary, and then pass control to ./manage.py ....
  • Add this script to the /openedx/bin folder of the openedx-dev image.
  • Set the openedx-dev image's ENTRYPOINT to ['set-up-and-run'].
  • Now, check that a mounted edx-platform can be run without needing to manually create the egg-info.
  • Update the documentation to remove pip install .... from the mounted edx-platform setup steps.
    ...

You can compare this with Option B here: #25

@kdmccormick kdmccormick force-pushed the kdmccormick/egg-info-entrypoint branch 2 times, most recently from ae439ce to c30b728 Compare January 11, 2023 19:14
@kdmccormick kdmccormick changed the title feat: remove need to pip-install edx-platform when it is mounted feat: use entrypoint to automatically pip-install mounted edx-platform Jan 11, 2023
@kdmccormick kdmccormick force-pushed the kdmccormick/egg-info-entrypoint branch from c30b728 to 8b39340 Compare January 11, 2023 19:33
@kdmccormick kdmccormick changed the title feat: use entrypoint to automatically pip-install mounted edx-platform feat: use entrypoint to automatically pip-install mounted edx-platform Jan 11, 2023
@kdmccormick kdmccormick force-pushed the kdmccormick/egg-info-entrypoint branch from 8b39340 to 0a18ecd Compare January 11, 2023 20:14
@kdmccormick kdmccormick force-pushed the kdmccormick/egg-info-entrypoint branch from 0a18ecd to 7f4524b Compare January 11, 2023 20:29
@kdmccormick
Copy link
Owner Author

Closed in favor of #25

@kdmccormick kdmccormick closed this Feb 7, 2023
@kdmccormick kdmccormick deleted the kdmccormick/egg-info-entrypoint branch February 7, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant