Merge pull request #37 from kalmarek/mk/AbstractPermutations

use AbstractPermutations.jl
kalmarek · Dec 4, 2023 · 06cea66 · 06cea66 · kalmarek · Dec 5, 2023
2 parents 773db9e + b0a09e2
commit 06cea66
Show file tree

Hide file tree

Showing 26 changed files with 207 additions and 639 deletions.
diff --git a/.JuliaFormatter.toml b/.JuliaFormatter.toml
@@ -0,0 +1,9 @@
+# Configuration file for JuliaFormatter.jl
+# For more information, see: https://domluna.github.io/JuliaFormatter.jl/stable/config/
+
+always_for_in = true
+always_use_return = true
+margin = 80
+remove_extra_newlines = true
+separate_kwargs_with_semicolon = true
+short_to_long_function_def = true
diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -0,0 +1,33 @@
+name: Check formatting
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  format:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '^1.6'
+      - uses: actions/checkout@v2
+      - name: Install JuliaFormatter and format
+        run: |
+          julia  -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter", version="1.0.9"))'
+          julia  -e 'using JuliaFormatter; format(["./src", "./test"], verbose=true)'
+      - name: Format check
+        run: |
+          julia -e '
+          out = Cmd(`git diff --name-only`) |> read |> String
+          if out == ""
+              exit(0)
+          else
+              @error "Some files have not been formatted !!!"
+              write(stdout, out)
+              exit(1)
+          end'
diff --git a/Project.toml b/Project.toml
@@ -1,14 +1,16 @@
 name = "PermutationGroups"
 uuid = "8bc5a954-2dfc-11e9-10e6-cd969bffa420"
 authors = ["Marek Kaluba <kalmar@amu.edu.pl>", "tweisser <tillmann.weisser@web.de>"]
-version = "0.4.3"
+version = "0.5.0"
 
 [deps]
+AbstractPermutations = "36d08e8a-54dd-435f-8c9e-38a475050b11"
 GroupsCore = "d5909c97-4eac-4ecc-a3dc-fdd0858a4120"
 PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 
 [compat]
+AbstractPermutations = "0.2"
 GroupsCore = "0.4"
 PrecompileTools = "1"
 julia = "1.6"

diff --git a/src/Perms/Perms.jl b/src/Perms/Perms.jl
diff --git a/src/Perms/abstract_perm.jl b/src/Perms/abstract_perm.jl
diff --git a/src/Perms/arithmetic.jl b/src/Perms/arithmetic.jl
diff --git a/src/Perms/cycle_decomposition.jl b/src/Perms/cycle_decomposition.jl