Allow event listener to mess up with executors and steps

kaliop-uk · Nov 14, 2016 · fa3295a · fa3295a
1 parent b85343a
commit fa3295a
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 3 deletions.
diff --git a/API/Event/BeforeStepExecutionEvent.php b/API/Event/BeforeStepExecutionEvent.php
@@ -32,4 +32,22 @@ public function getExecutor()
     {
         return $this->executor;
     }
+
+    /**
+     * Here be dragons
+     * @param ExecutorInterface $executor
+     */
+    public function replaceExecutor(ExecutorInterface $executor)
+    {
+        $this->executor = $executor;
+    }
+
+    /**
+     * Lasciate ogni speranza, voi ch'entrate
+     * @param MigrationStep $step
+     */
+    public function replaceStep(MigrationStep $step)
+    {
+        $this->step = $step;
+    }
 }
diff --git a/Core/Executor/ContentManager.php b/Core/Executor/ContentManager.php
@@ -321,11 +321,11 @@ protected function setFields($createOrUpdateStruct, array $fields, ContentType $
                 $fieldValue = $field;
             }
 
-            $fieldType = $contentType->fieldDefinitionsByIdentifier[$fieldIdentifier];
-            if ($fieldType == null) {
+            if (!isset($contentType->fieldDefinitionsByIdentifier[$fieldIdentifier])) {
                 throw new \Exception("Field '$fieldIdentifier' is not present in field type '{$contentType->identifier}'");
             }
 
+            $fieldType = $contentType->fieldDefinitionsByIdentifier[$fieldIdentifier];
             $fieldValue = $this->getFieldValue($fieldValue, $fieldType, $contentType->identifier, $this->context);
 
             $createOrUpdateStruct->setField($fieldIdentifier, $fieldValue, $this->getLanguageCode());

diff --git a/Core/MigrationService.php b/Core/MigrationService.php
@@ -226,7 +226,11 @@ public function executeMigration(MigrationDefinition $migrationDefinition, $useT
                 // we validated the fact that we have a good executor at parsing time
                 $executor = $this->executors[$step->type];
 
-                $this->dispatcher->dispatch('ez_migration.before_execution', new BeforeStepExecutionEvent($step, $executor));
+                $beforeStepExecutionEvent = new BeforeStepExecutionEvent($step, $executor);
+                $this->dispatcher->dispatch('ez_migration.before_execution', $beforeStepExecutionEvent);
+                // allow some sneaky trickery here: event listeners can manipulate 'live' the step definition and the executor
+                $executor = $beforeStepExecutionEvent->getExecutor();
+                $step = $beforeStepExecutionEvent->getStep();
 
                 $result = $executor->execute($step);
 

diff --git a/WHATSNEW.md b/WHATSNEW.md
@@ -1,3 +1,9 @@
+Version 3.0.0-beta4
+===================
+
+* New: It is now possible to replace the executor and step definition in a BeforeStepExecutionEvent
+
+
 Version 3.0.0-beta3
 ===================