Move close operation out of synchronized block #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change may enhance performance if close operation take a long time
|
Before merging this, can you take a look at #47 - Specifically how to handle the case where an exception is thrown in one of the threads and then what should happen when another thread tries to access the resource. |
| case None => | ||
| throw new IllegalStateException | ||
| } | ||
| } | ||
| if (newValue.isEmpty) { | ||
| implicitly[Resource[A]].close(r) |
There was a problem hiding this comment.
This could be called multiple times, which I think is unsafe, concurrency-wise
There was a problem hiding this comment.
But it will never be called multiple times for the same r instance
|
The more I think about it the more I'm hesitant on multi-threading features without more multi-threaded controls, especially if we don't know whether theunderlying resource is "concurrency safe" |
cchantep
reviewed
Jul 9, 2019
| if (oldReferenceCount == 1) { | ||
| implicitly[Resource[A]].close(sc) | ||
| sharedReference = None | ||
| val newValue = if (oldReferenceCount == 1) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change may enhance performance if close operation take a long time