Docker file created #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i was getting lots of issue during installation of composer and php so here i have a docker to run it
jmikola
reviewed
Jul 11, 2017
Dockerfile
Outdated
|
|
||
| #Install composer php and mongodb | ||
| RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv EA312927 \ | ||
| && echo "deb http://repo.mongodb.org/apt/debian wheezy/mongodb-org/3.2 main" | tee /etc/apt/sources.list.d/mongodb-org-3.2.list \ |
There was a problem hiding this comment.
Is there a reason for deploying MongoDB within the Docker container? The purpose of the application is to connect to an existing MongoDB cluster to work with its system.profile collections. Having the application connect to its own MongoDB instance (with no data) doesn't have much value.
|
relvent changes has been done please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was getting lots of issue during installation of composer and php so here i have a docker to run it