-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated jsdom to 25.0.1 - fixes Deprecation warning for 'punycode' #15417
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
e67b589
to
339beff
Compare
…ry test execution
554e518
to
3272993
Compare
3272993
to
8b871c4
Compare
58d265b
to
0011bf0
Compare
Hey! This is a breaking change we can't take as it'd mean dropping support for node versions we don't want to. You should be able to update |
@SimenB Forgive my curiosity, but is there a particular reason for the attachment to Node v16? Its end-of-LTS is typically the "go ahead" for others to drop support for it. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Updated jsdom to 25.0.1,
Summary
This fixes the Deprecation Warning in every test execution. See: https://github.com/jsdom/jsdom/releases/tag/25.0.1
Updated dependencies, notably tough-cookie, which no longer prints a deprecation warning.
the new jsdom version includes an update of tough-cookie, that no longer uses a deprecated dependency "punycode".
Test plan