Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated jsdom to 25.0.1 - fixes Deprecation warning for 'punycode' #15417

Closed
wants to merge 3 commits into from

Conversation

hutzelknecht
Copy link

Updated jsdom to 25.0.1,

Summary

This fixes the Deprecation Warning in every test execution. See: https://github.com/jsdom/jsdom/releases/tag/25.0.1
Updated dependencies, notably tough-cookie, which no longer prints a deprecation warning.

the new jsdom version includes an update of tough-cookie, that no longer uses a deprecated dependency "punycode".

Test plan

Copy link

linux-foundation-easycla bot commented Dec 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0011bf0
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/67593e5e71de1b00082d7359
😎 Deploy Preview https://deploy-preview-15417--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hutzelknecht hutzelknecht force-pushed the update-tough-cookie-5 branch 2 times, most recently from 554e518 to 3272993 Compare December 11, 2024 07:14
@SimenB
Copy link
Member

SimenB commented Jan 15, 2025

Hey! This is a breaking change we can't take as it'd mean dropping support for node versions we don't want to.

You should be able to update psl in your own project to avoid the deprecation warning.

#15217 (comment)

@jeremy-daley-kr
Copy link

@SimenB psl doesn't have an upgrade that removes punycode, hence the reason tough-cookie chose an alternative. I wouldn't recommend adding a package.json resolution, because that would force all dependents of it to use a potentially breaking change.

Forgive my curiosity, but is there a particular reason for the attachment to Node v16? Its end-of-LTS is typically the "go ahead" for others to drop support for it.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants