Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indentation of 2 when rewriting auto-migrated config file #4312

Merged

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

Use indentation of 2 when rewriting auto-migrated config file. This seems to be what most people use when indenting yaml files, and it seems to make more sense than the default of 4. We also use it the example config in Config.md.

This seems to be what most people use when indenting yaml files, and it seems to
make more sense than the default of 4.

We also use it the example config in Config.md.
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1e050551 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1e05055) Report Missing Report Missing Report Missing
Head commit (87c3e75) 53088 45986 86.62%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4312) 12 12 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@ChrisMcD1 ChrisMcD1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sweet, didn't know it would be this easy!

@stefanhaller stefanhaller added the ignore-for-release This will exclude the PR from release notes label Feb 23, 2025
@stefanhaller
Copy link
Collaborator Author

@jesseduffield I'm going to merge this, I hope you are fine with Chris' review.

I wasn't sure what label to assign, I picked "ignore-for-release" for now as I don't find it super important to mention it in release notes, but feel free to assign another one that you find more appropriate.

@stefanhaller stefanhaller merged commit 626ca18 into master Feb 23, 2025
14 of 15 checks passed
@stefanhaller stefanhaller deleted the use-indentation-of-2-when-rewriting-config-file branch February 23, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release This will exclude the PR from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants