Fix the save/load cluster configuration on disk and in memory #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekton Cluster configuration is not persisted on disk (save/load) and is lost at next reboot. Moreover, configuration update are not properly sotred in memory, preventing users to access to new configuration added (other than the default one). Fixes jenkinsci#106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tekton Cluster configuration is not persisted on disk (save/load) and is
lost at next reboot. Moreover, configuration update are not properly
stored in memory, preventing users to access to new configuration added
(other than the default one).
Remove the transient attribute to the config list (clusterConfigs) preventing to be saved/loaded by XStream toXml.
Add an explicit call to configChange in order to update the in memory configuration in TektonUtils
Fixes #106