-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.1 Rebuild Immeadiately for easier compatability with scripts and o… #51
base: master
Are you sure you want to change the base?
Conversation
…ther applications.
I'll try to free some time tomorrow to review this. Thanks for the contribution! |
return; | ||
} | ||
project.checkPermission(Item.BUILD); | ||
if (isRebuildAvailable()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what i understand, this is the key area that needs to change. Ideally, we can just skip the step where collect the user input through the form. I think what I have here will still throw exceptions because it tries to parse a form that may not be collected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that the best (and easiest way) would be to serialize all source build's ParametersActions and then deserialize them to essentially achieve a deep copy. Re-add them when scheduling the new build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give me a little more detail please? Do you mean serializing and deserializing immediately? Is there somewhere in the existing code to look at?
Hello GLundh, I've been reviewing my user story more, and I don't think it warrants this pull request after all. Does the rebuild plugin have any way of triggering a parameterized build other than the GUI? I'm trying to understand the code, does it accept post forms? |
I cannot edit any files without the plugin crashing. Can you point me towards how you package the plugin? Feb 07, 2018 11:56:57 AM hudson.ExpressionFactory2$JexlExpression evaluate
|
…ther applications. I would love help testing and completing, are advice from previous contributors. This is my first Jenkins contribution :)