Some smaller housekeeping

[eva-mueller-coremedia]

When implementing #480 I got aware of some things which can be cleaned up like

• Typos
• Unused methods
• Simplifications
• JavaDoc alignments
• Some additional tests

Testing done

Only covered by unit tests.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.05%. Comparing base (13300b6) to head (4d375cd).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java	37.50%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #509      +/-   ##
============================================
+ Coverage     72.55%   73.05%   +0.50%     
  Complexity      248      248              
============================================
  Files            20       20              
  Lines          1115     1106       -9     
  Branches        154      152       -2     
============================================
- Hits            809      808       -1     
+ Misses          210      204       -6     
+ Partials         96       94       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eva-mueller-coremedia]

Unfortunately, I do not know how to achieve the target 72.55%. There is code which can be tested because it is there only for backwards compatibility and can't be reached easily due to missing setters. Or at least my knowledge how to mock these are too limited here.