-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent NullPointerException when using API token w/o OIC session #483
base: master
Are you sure you want to change the base?
Prevent NullPointerException when using API token w/o OIC session #483
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
============================================
+ Coverage 72.04% 73.12% +1.08%
- Complexity 235 245 +10
============================================
Files 18 18
Lines 1073 1079 +6
Branches 149 148 -1
============================================
+ Hits 773 789 +16
+ Misses 207 197 -10
Partials 93 93 ☔ View full report in Codecov by Sentry. |
0b1d642
to
da564b7
Compare
@jtnord @michael-doubez would be great if you could have a look. |
81e946f
to
7b36797
Compare
7b36797
to
f85386c
Compare
Sorry for nudging again - @jtnord @michael-doubez would be great if you could have a look. |
LGTM but the change is very big and I'd prefer if @jtnord had a look |
Also add tests per extracted method
f85386c
to
f2dfc3e
Compare
I rebased onto the default branch. Commit-wise review is suggested. This PR contains a fix and just some splitting up of the Plugin Test class into smaller pieces resp. outsources helper / mock methods to own classes. |
I encountered warnings in my IDE about potential NPEs and fixed them accordingly.
In the course of this small fix, I tried to understand the integration test in
PluginTest.java
and found it a little bit ... grown.Thus I made some housekeeping
PluginTest.java
into own test filesTesting done
This change has solely tested by the integration test in
PluginApiTokenTest.java
.Submitter checklist