Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9 #1263

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9 #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ff4f9
Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9
dependabot[bot] Mar 5, 2025
e286c45
Remove unnecessary suppressions
MarkEWaite Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>5.8</version>
<version>5.9</version>
<relativePath />
</parent>

Expand Down
3 changes: 0 additions & 3 deletions src/main/java/hudson/plugins/git/Revision.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import static java.util.stream.Collectors.joining;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.Util;
import java.io.Serial;
import java.util.ArrayList;
Expand Down Expand Up @@ -54,7 +53,6 @@ public Revision(ObjectId sha1, Collection<Branch> branches) {
*
* @return a {@link org.eclipse.jgit.lib.ObjectId} object.
*/
@SuppressFBWarnings(value = "NM_CONFUSING", justification = "Published API in GitObject and Revision")
public ObjectId getSha1() {
/* Returns an immutable ObjectId to avoid caller modifying ObjectId using returned ObjectId */
return (sha1 == null) ? null : sha1.toObjectId();
Expand All @@ -65,7 +63,6 @@ public ObjectId getSha1() {
*
* @return a {@link java.lang.String} object.
*/
@SuppressFBWarnings(value = "NM_CONFUSING", justification = "Published API in GitObject and Revision")
@Exported(name = "SHA1")
public String getSha1String() {
return sha1 == null ? "" : sha1.name();
Expand Down
9 changes: 0 additions & 9 deletions src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2199,10 +2199,6 @@ private String launchCommandWithCredentials(
}
}

@SuppressFBWarnings(
value = "DMI_HARDCODED_ABSOLUTE_FILENAME",
justification =
"Path operations below intentionally use absolute '/usr/bin/chcon' and '/sys/fs/selinux/enforce' and '/proc/self/attr/current' at this time (as delivered in relevant popular Linux distros)")
private Boolean fixSELinuxLabel(Path key, String label) {
// returning false means chcon was tried and failed,
// maybe caller needs to retry with other logic
Expand Down Expand Up @@ -2772,15 +2768,10 @@ private String launchCommandIn(ArgumentListBuilder args, File workDir, EnvVars e
return launchCommandIn(args, workDir, environment, TIMEOUT);
}

@SuppressFBWarnings(
value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE",
justification = "earlier readStderr()/readStdout() call prevents null return")
private String readProcessIntoString(Proc process, String encoding, boolean useStderr) throws IOException {
if (useStderr) {
/* process.getStderr reference is the findbugs warning to be suppressed */
return IOUtils.toString(process.getStderr(), encoding);
}
/* process.getStdout reference is the findbugs warning to be suppressed */
return IOUtils.toString(process.getStdout(), encoding);
}

Expand Down
4 changes: 0 additions & 4 deletions src/main/java/org/jenkinsci/plugins/gitclient/JGitAPIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,9 +1612,6 @@ public CloneCommand depth(Integer depth) {
return this;
}

@SuppressFBWarnings(
value = "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE",
justification = "JGit interaction with spotbugs")
private RepositoryBuilder newRepositoryBuilder() {
RepositoryBuilder builder = new RepositoryBuilder();
builder.setGitDir(new File(workspace, Constants.DOT_GIT)).readEnvironment();
Expand Down Expand Up @@ -3141,7 +3138,6 @@ public String getDefaultRemote(String _default_) throws GitException, Interrupte
/** {@inheritDoc} */
@Deprecated
@Override
@SuppressFBWarnings(value = "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE", justification = "JGit interaction with spotbugs")
public void setRemoteUrl(String name, String url, String GIT_DIR) throws GitException, InterruptedException {
try (Repository repo =
new RepositoryBuilder().setGitDir(new File(GIT_DIR)).build()) {
Expand Down
Loading