-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the provided style to the summary text #210
Apply the provided style to the summary text #210
Conversation
add missing `$` in summary template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I confirmed that the incorrect style is added to the build job of the page when I run a Pipeline:
The HTML page for that build shows the "home" icon with the text "Sample" and the style is '{it.cssClass}' instead of being the expanded CSS class. I think that an automated test should be possible to check that, but even if there is not an automated test, my interactive test shows the bug before this change. |
Testing after the change confirms that the style is no longer "{it.cssClass}" |
$
in summary template
Hello, when can we expect a new release of the plugin with this fix? |
I just released version 2.6 of the plugin. Sorry for the delay 😞 |
@strangelookingnerd what about automated release? https://www.jenkins.io/doc/developer/publishing/releasing-cd/ When you want, I can provide the changes also for this plugin. |
No objections from my end. Not the biggest fan of automated releases but I don't mind enabling them on this plugin. |
add missing
$
in summary templateTesting done
Submitter checklist