Properly handle empty values

jenkinsci · Nov 19, 2024 · d9f8ec7 · d9f8ec7
1 parent 59716c5
commit d9f8ec7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java b/src/main/java/com/jenkinsci/plugins/badge/action/AbstractBadgeAction.java
@@ -87,7 +87,7 @@ public void setIcon(String icon) {
 
     @Whitelisted
     public String getIcon() {
-        if (StringUtils.isEmpty(icon)
+        if (StringUtils.isBlank(icon)
                 || icon.startsWith("/")
                 || icon.startsWith("symbol-")
                 || icon.startsWith("icon-")
@@ -122,7 +122,7 @@ public void setText(String text) {
 
     @Whitelisted
     public String getText() {
-        if (StringUtils.isEmpty(text)) {
+        if (StringUtils.isBlank(text)) {
             return text;
         }
 
@@ -161,14 +161,14 @@ public void setLink(String link) {
 
     @Whitelisted
     public String getLink() {
-        if (StringUtils.isEmpty(link)
+        if (StringUtils.isBlank(link)
                 || link.startsWith("/")
                 || link.matches("^https?://.*")
                 || link.matches("^mailto:.*")) {
             return link;
         }
 
-        LOGGER.log(Level.WARNING, "Invalid link value: '{}' - ignoring it", link);
+        LOGGER.log(Level.WARNING, () -> "Invalid link value: '" + link + "' - ignoring it");
         return null;
     }