Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#983 Fixing build instructions #985

Merged
merged 2 commits into from
Mar 11, 2024
Merged

#983 Fixing build instructions #985

merged 2 commits into from
Mar 11, 2024

Conversation

isgallagher
Copy link
Contributor

Fixes #983 , continuation of #984. I don't know how that PR got closed. As mentioned, this patch includes updating the ci and project xcode config path variables. It should build if the cache is cleared as apple/swift-logs is failing due to a cached older version.

@LePips
Copy link
Member

LePips commented Mar 3, 2024

The Homebrew + Swiftgen issue has been fixed, so we would only need the Casting SDK. What we can actually do for now is fix the URL and comment it out in the Cartfile, it isn't being used.

Disable ChromeCastFramework in Carthage
Update PATH vars in project.pbxproj
@isgallagher
Copy link
Contributor Author

isgallagher commented Mar 4, 2024

The Homebrew + Swiftgen issue has been fixed, so we would only need the Casting SDK. What we can actually do for now is fix the URL and comment it out in the Cartfile, it isn't being used.

Changes made, and it builds locally. For some reason caching of apple/swift-log causes the build to fail. Deleting the cache and running the build works, but subsequent with caching enabled fails.

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what's up with the cache and that specific package. That'll be annoying for at least a while.

@LePips LePips merged commit 11cc5f5 into jellyfin:main Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building is broken
2 participants