Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Swift Symbol Generation for Assets Catalogs #955

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Jan 25, 2024

This setting was introduced in Xcode 15 and allows for Swift symbols to be generated for Color and Image asset catalogs so that they can be validated by the compiler. Changing an asset name will result in a compiler error rather than a runtime crash 🙂

There is an asset named git.commit that doesn't appear to be used, is that safe to remove or are there plans to use it?

@chickdan chickdan marked this pull request as draft January 25, 2024 02:53
@chickdan
Copy link
Contributor Author

CI runs on Xcode 14.2 causing the build to fail. I'll open a PR to update the CI pipelines.

@chickdan chickdan marked this pull request as ready for review January 25, 2024 05:00
@chickdan chickdan marked this pull request as draft January 31, 2024 19:26
@LePips
Copy link
Member

LePips commented Feb 20, 2024

As a note, the runners now use Xcode 15 by default.

@chickdan
Copy link
Contributor Author

chickdan commented Mar 7, 2024

As a note, the runners now use Xcode 15 by default.

I was still getting errors on my fork after they switched the default and I haven't had time to dig into it. I'll hopefully get back to this soon 🙂

@chickdan chickdan marked this pull request as ready for review March 12, 2024 22:25
@LePips LePips merged commit 876ffba into jellyfin:main Mar 13, 2024
6 checks passed
@chickdan chickdan deleted the swift_symbol_asset_catalog branch June 6, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants