[iOS & tvOS] Fix Clipping Add User Button #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems to resolve it for me as well! Would you be able to mirror that on tvOS as well: /Swiftfin tvOS/Views/SelectUserView/Components/UserGridButton.swift Looks like the same fix there on L66 & L67. I'll defer to @LePips if there is any Swift reason this shouldn't be added but otherwise it looks good to me! |
LePips
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Hm the "clipping" is due to the ScrollIfLargerThanContainer setting the frame and the size not being reported correctly, as well as some oddities with my current on[Size|Frame]Changed wrappers. Unknown why setting the aspect ratio and clip shape again fixes it.
I played around with some clean up but will defer that to later.
JPKribs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure why this is necessary but it was the only difference I can spot after the change in #1328
Fixes #1425