Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS & tvOS] Use AboutView for Series Poster Routing #1438

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Feb 20, 2025

Summary

This is a fairly small change and might not make sense. For episodes, this removes the "Series" section. Instead, if the ViewModel.Item.Type is .episode, the ImageCard routes the user to the Series. Otherwise, this continues to just be a poster. Works for both iOS and tvOS.

This removes the mostly empty "Series" section that kind of looks out of place with a single item. The only downside is it may not be directly obvious this button routes to the Series.

This change makes sense to me as I keep tapping this poster thinking it will take me back to the series. Let me know if this is too ambiguous. My idea for making this less ambiguous is, if the item is not an episode, just move focus back to the top of the page. That way it's always a button but we're not routing anyone from the ItemView back to the same ItemView.

Video (tvOS)

Simulator.Screen.Recording.-.Apple.TV.4K.3rd.generation.-.2025-02-20.at.14.26.08.mp4

…herwise, continue using that image as just an image. tvOS & iOS.
@JPKribs JPKribs added the enhancement New feature or request label Feb 20, 2025
@JPKribs JPKribs changed the title [iOS & tvOS] Use About View for Series Poster Routing [iOS & tvOS] Use AboutView for Series Poster Routing Feb 20, 2025
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but how this is communicated is a concern. An additional route to the series from episodes could be making the series name on the views a Button, as tapping the series name isn't an uncommon interaction.

@LePips LePips merged commit 35b72b3 into jellyfin:main Feb 23, 2025
4 checks passed
@JPKribs JPKribs deleted the customAbout branch February 23, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants