Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a scenarios list filter when adding a scenario in a scenario modification #2683

Closed
wants to merge 1 commit into from

Conversation

noodom
Copy link
Contributor

@noodom noodom commented Jun 11, 2024

Add a scenarios list filter when adding a scenario in a scenario modification

Description

The PR adds a filter to the scenarios list when the action 'scenario' is added.
Only matching scenarios to the filter (scenario name, scenario group or scenario object parent) are visible in the list.

Suggested changelog entry

add a scenarios list filter in a scenario

Types of changes

  • Bug fix (non-breaking change which fixes)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • [x ] I have checked there is no other PR open for the same change.
  • [ x] I have read the [La ligne directrice pour contribuer à ce projet / Contribution guidelines for this project).
  • [x ] I grant the project the right to include and distribute the code under the GNU.
  • I have added tests to cover my changes.
  • [ x] I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added MD documentation for the sniff.

@zoic21
Copy link
Contributor

zoic21 commented Jun 13, 2024

Bonjour,
Merci pour ce PR par contre je pense ca peut poser soucis si le template est appellé plusieurs fois sur la meme page. Ca risque de faire plusieurs fois la fonction addScenariosFilter ou l'écraser. Vu que la fonction n'est appelé qu'a un seul endroit il y a peut etre moyen de ne pas faire de fonction justement.

@zoic21
Copy link
Contributor

zoic21 commented Jun 19, 2024

Je pense que celui la peut etre fermé vu qu'on a passé l'autre non ?

@noodom noodom closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants