Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update django-phonenumber-field to 8.x.x #730

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Update django-phonenumber-field to 8.x.x #730

merged 1 commit into from
Jul 24, 2024

Conversation

hansegucker
Copy link
Member

Motivation and Context

Fix compatibility with django-phonenumber-field 8.0.0

How Has This Been Tested?

Automatic test suite ran through

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hansegucker hansegucker requested a review from moggers87 July 17, 2024 09:56
claudep
claudep requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a minor change and we are good to go!

@hansegucker hansegucker force-pushed the update-django-phonenumber-field branch from 4e625ca to 4572a36 Compare July 24, 2024 17:32
claudep
claudep approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claudep claudep merged commit 0027b69 into master Jul 24, 2024
13 checks passed
@claudep claudep deleted the update-django-phonenumber-field branch July 24, 2024 17:46
@hansegucker
Copy link
Member Author

Thanks!

Also thanks! Can we release this soon?

@claudep
Copy link
Contributor

claudep commented Aug 12, 2024

1.17.0 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

@moggers87 moggers87 Awaiting requested review from moggers87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansegucker @claudep