Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5.0 forces POST method for logouts #704

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Django 5.0 forces POST method for logouts #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/test_views_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ def test_with_remember(self):
self.assertEqual(1, len([cookie for cookie in response.cookies if cookie.startswith('remember-cookie_')]))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))
response = self.client.get('/secure/raises/')
self.assertEqual(response.status_code, 403)

Expand Down Expand Up @@ -733,7 +733,7 @@ def test_without_remember(self):
self.assertEqual(0, len([cookie for cookie in response.cookies if cookie.startswith('remember-cookie_')]))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))
response = self.client.get('/secure/raises/')
self.assertEqual(response.status_code, 403)

Expand All @@ -758,7 +758,7 @@ def test_expired(self):
self.assertEqual(1, len([cookie for cookie in response.cookies if cookie.startswith('remember-cookie_')]))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))
response = self.client.get('/secure/raises/')
self.assertEqual(response.status_code, 403)

Expand Down Expand Up @@ -790,7 +790,7 @@ def test_wrong_signature(self):
self.assertEqual(1, len([cookie for cookie in response.cookies if cookie.startswith('remember-cookie_')]))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))
response = self.client.get('/secure/raises/')
self.assertEqual(response.status_code, 403)

Expand Down Expand Up @@ -822,7 +822,7 @@ def test_remember_token_throttling(self):
self.assertEqual(1, len([cookie for cookie in response.cookies if cookie.startswith('remember-cookie_')]))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))

# Login having an invalid remember cookie
self.set_invalid_remember_cookie()
Expand Down Expand Up @@ -877,7 +877,7 @@ def test_phonedevice_with_remember_cookie(self, mock_signal, fake):
self.assertRedirects(response, resolve_url(settings.LOGIN_REDIRECT_URL))

# Logout
self.client.get(reverse('logout'))
self.client.post(reverse('logout'))

# Ask for SMS challenge
response = self._post({'auth-username': 'bouke@example.com',
Expand Down
Loading