-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: deprecate borderless-accounts endpoint, and provide account-detail and balance-statement endpoints. #25
Conversation
…atements endpoint
…t is listed as deprecated? Ref: <https://docs.wise.com/api-docs/api-reference/deprecated>
… endpoint is listed as deprecated?" This reverts commit dd17ef8.
Looks good from a read! This still requires SCA, is that done differently to the old endpoints, or are we still going to need to find an alternative to private keys? We obviously need to make this change, but I'm just wondering if this takes away the potential imminent doom from #24. |
Thanks! My sense - and I'll check again tomorrow because I already had to remind myself - is that for business accounts, retrieving statements using signature-based authentication is still OK. That's not something I've confirmed with Wise, though. |
Relates-to commit 3586caf.
…-longer-documented borderless-accounts statement endpoint.
It's likely going to make sense to introduce some datatypes (
dataclasses
perhaps?) for the result objects in the nearish future; for now though, make the endpoints available.My understanding is that the
DeprecationWarning
is unlikely to appear in many downstream applications at runtime, since it's ignored by default; it's most likely to appear when test suites run.Resolves #24.