-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nix flake to package for NixOS #263
base: master
Are you sure you want to change the base?
Conversation
Hi, thank you for the PR. I am unfamiliar with NixOS and flake. Could you please explain why this is needed, how installation would work on NixOS and whether the files have to be at the root of the repository? (I would rather prefer adding a folder for packaging instead of cluttering root) |
This has been stale for a while. Any chance you can answer my questions? I am not against merging this, but would need to understand a bit more about it |
Hi, apologies for my late response Nix is a package management system based on Nix's functional programming language. Ideally, we should submit the package to nixpkgs to include it in Nix distribution. (I didn't due to unfamiliarity with the community and lack of time, but I will do at some point). The next best thing is to include a flake for Nix users. Now for why it has to be in the root, it doesn't have to be, but having it at the root of the repo is more convenient. Here are some possibilities: At root of a branchIn my fork of LibreVNA, I have a branch called nix run github:mtahernia/LibreVNA/nixos-support This will pull the repo and build it and run the software. (also can install with nix,...) At root of the main branchIf the files were in the main branch, you can omit the branch and simply run nix run github:jankae/LibreVNA In the subdirectory of a branchThey can also be in a subdirectory. Imagine flake.nix and flake.lock are located in nix run github:jankae/LibreVNA/test_branch?dir=package/nix In a separate repo containing only the
|
I don't maintain any C++ packages on nixpkgs, but I do maintain a couple others. I think that it would make sense to open a PR there. I can offer some review at least. It would also be okay to simultaneously have a flake here, but if jankae is unfamiliar with it, it may become a maintenance burden as the project evolves, unless a contributor offers help maintaining the flake of course! |
I added a Nix flake to package the LibreVNA-GUI for NixOS users.