Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual port oper-state change notification to the yang model #5

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

pkaminsk
Copy link
Collaborator

Change Scope

Add virtual port status notification definition to the virtual port yang model.

notifications:
+---n oper-status-change {oper-status-change-notification}?
+--ro global-resource-id uint32
+--ro oper-status enumeration

Signed-off-by: Kaminski, Pawel <pawel.kaminski@intel.com>
Signed-off-by: Kaminski, Pawel <pawel.kaminski@intel.com>
@pkaminsk pkaminsk requested a review from 5abeel February 14, 2025 00:12
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


leaf oper-status {
type enumeration {
enum UP {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using UP and DOWN seems better than using the LINK_UP and LINK DOWN as used in the oper-status above. This also aligns better with other models such as the oc:interfaces model where oper-status is indicated by just UP and DOWN enums.

@pkaminsk pkaminsk merged commit bfaaabb into ipdk-io:master Feb 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants