New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovsp4rt] Implement HaveTableEntry predicates #736

Closed

ffoulkes wants to merge 41 commits into main from HaveTableEntry

Contributor

ffoulkes commented Jan 12, 2025 •

edited

Loading

Implemented HaveTableEntry predicates as wrappers around the GetTableEntry functions. Modified the code to use the predicates when the purpose of the read request is to test for the existence of an entry.

This PR is ES2K-specific. Only ES2K functions call the GetTableEntry and HaveTableEntry functions.

ffoulkes and others added 30 commits

October 2, 2024 09:13


          Summary of ovsp4rt encoding anomalies (#692)

e760e98

Document that summarizes apparent encoding issues in ovsp4rt.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          [ovsp4rt] Improve journal encoding (#693)

5804b67

- Encode and validate IPv6 addresses as arrays of uint16_t.
  This allows us to provide better feedback in case of a
  mismatch.

- Make a couple of minor changes to encode_addr_test.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Display default P4OVS mode in help text (#695)

1a63bc0

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Implement CMakePresets file (#694)

508c9ce

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Update CMakePresets.json file (#696)

81aaa7c

- Enabled CMAKE_EXPORT_COMPILE_COMMANDS. This option instructs CMake
  to generate a `compile_commands.json` file in the build directory,
  for use by other tools (such as `clang-tidy`)

- Expanded CMAKE_INSTALL_PREFIX to an absolute path, which is what
  happens when you set `CMAKE_INSTALL_PREFIX` on the CMake command
  line.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Define list of values for P4OVS_MODE variable (#697)

46aab66

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Fix problem setting property on P4OVS_MODE (#698)

dd5fd8d

- Moved the set_property() for the STRINGS property on P4OVS_MODE
  after its definition. This fixes a CMake configuration error
  that cropped up in the Tofino build.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Bump actions/setup-go from 5.0.2 to 5.1.0 (#699)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5.0.2...v5.1.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          Add CMakeUserPresets to .gitignore (#700)

ddc000a

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Define install-path-presets (#702)

42b8425

- Implemented an `install-path-presets` preset that defines
  DEPEND_INSTALL_DIR and SDE_INSTALL_DIR from the DEPEND_INSTALL
  and SDE_INSTALL environment variables.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          cmake sample scripts (#703)

eb4c9f2

- Added sample cmake pre-load scripts and a user presets file,
  and updated the buildsystem to install them in the `share`
  directory tree.

- Added /dpdk.cmake and /es2k.cmake to .gitignore.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Minor improvements to README file (#704)

cbb1c0d

- Sanitized a couple of file paths.

- Changed "pre-load" to "preload". The CMake documentation uses
  the hyphenated form, but I find it distracting.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Remove p4cpconfig script (#705)

ee2919d

- Removed the experimental p4cpconfig script. It has been
  superseded by cmake presets.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Update .gitignore file (#706)

bd7f495

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Scripts to generate unit test coverage reports (#708)

cdd01f3

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Mark development options as advanced (#707)

86d2724

- Marked the BUILD_JOURNAL and BUILD_SPIES variables as advanced.
  They are internal options, used to enable features that are
  still under development, and should normally be hidden.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Define usage message for infrap4d (#709)

f89e5f0

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Mark IPDK_ROLE_FIXED variable as advanced (#710)

696ff26

- This is an internal variable intended for use by developers.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Implement uninstall target

044d4da

- Added logic to generate an uninstall script and defined a
  target to run the script.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Update ovs cmake configuration (#711)

0d7da97

- Created an experimental CMakePresets.json file.

- Defined property strings for the P4OVS_MODE variable.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          Update submodules (#712)

fc2d667

- Updated the stratum and krnlmon submodule references.

Signed-off-by: Derek Foster <derek.foster@intel.com>


          [ovsp4rt] Implement Client class (#713)

e3ba056

- Implemented the `Client` `ClientInterface`, and `ClientMock`
  classes, to abstract the interface to the P4Runtime server.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Minor maintenance (#714)

92f8b86

- Renamed the Journal "schema" element to "version".

- Added `const` qualifier to a couple of parameters.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          Bump actions/setup-go from 5.1.0 to 5.2.0 (#715)

91e486a

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5.1.0...v5.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          Remove session() method from Client class (#716)

b5c1e16

The purpose of the `Client` class is to replace the discrete logic
that interacts with the P4Runtime server with an object that
implements an abstract interface.

- `ClientInterface` is an abstract class that defines the interface.
- `Client` is an implementation of `ClientInterface` that replaces
  the current discrete logic.
- `ClientMock` is a mock implementation of `ClientInterface`.

For this to work, we need to hide the session object from the user.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Fix errors in sidecar build files (#717)

d641e71

- Modified CMakeLists.txt files to fix compile and link
  errors when building with BUILD_CLIENT enabled.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          Pin workflow scripts to Ubuntu-22.04 (#722)

376bd02

- Changed `ubuntu-latest` to `ubuntu-22.04` in the workflows,
  in preparation for GitHub bumping ubuntu-latest to 24.04.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Implement journaling client (#719)

b5029f2

* [ovsp4rt] Implement journaling api and client

- Created JournalClient, a subclass of Client that is
  instrumented to record interactions between OVS and
  the P4Runtime server.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>

* [ovsp4rt] Rough in new Journal methods

- Added methods to the Journal class to record P4Runtime server
  requests and responses.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>

---------

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Separate C API functions from rest of code (#720)

f570842

- Moved the C API wrapper functions to a separate source
  file. This makes it possible to substitute a different
  implementation of the API, for testing.

  Extracted from PR #674. Works with an updated version
  of ovsp4rt.cc that has not been committed. Currently
  excluded from the build.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Implement journaling API (#721)

ea545c2

- Created a variant of the public API that uses
  JournalClient objects.

  Extracted from PR #674. Works with several files that
  have not yet been committed, or that are being committed
  separately. Currently excluded from the build.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>

ffoulkes added 11 commits

January 1, 2025 10:42


          Update to stratum-deps v1.3.4 (#723)

1eafa1e

* Update to stratum-deps v1.3.4
* Update stratum submodule to v3.3.0.0

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          Update ovs submodule to v3.3.0.0 (#724)

11d1922

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Minor housekeeping (#725)

2b0173f

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Update comments (#726)

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Fix copy/paste error in p4info_text.h (#730)

f3c11f9

- Corrected ES2K to DPDK in the DPDK version of the file.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          Update copyright dates (#731)

2bebd56

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Implement Client class (#732)

4a92a84

- Updated cmake listfile to use `newovsp4rt.cc` instead of
  `ovsp4rt.cc` when the BUILD_CLIENT option is enabled.

- Modified newovsp4rt.cc to use a `Client` object instead of an
  `OvsP4rtSession` object to communicate with the P4Runtime server.

- Made each public C API function a wrapper around a C++ function
  that accepts a `Client` object as a parameter. This allows a
  test to replace the object with a test double (e.g. a mock).

- Moved the C API functions to another file
  (`ovsp4rt_standard_api.cc`), separating the user interface from
  the implementation.

- Created a second implementation of the C API
  (`ovsp4rt_journal_api.cc`) that enables journaling.

- Added an `ovsp4rt_build_and_test` job to the pipeline, to verify
  that ovsp4rt builds when BUILD_CLIENT and BUILD_JOURNAL are enabled.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Extract ovsp4rt_str_to_tunnel_type() (#735)

78c712b

- Moved ovsp4rt_str_to_tunnel_type() to a separate source
  file for C api functions that are not wrappers.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Rename internal API functions (#733)

cab89dc

- Renamed the functions in the internal C++ API from
  ConfigEntry to DoConfigEntry, to keep them from being
  confused with ConfigTableEntry functions.

The conventions are:

- A PrepareTableEntry function populates the fields of a
  TableEntry.

- A ConfigTableEntry function initializes a WriteRequest,
  prepares the TableEntry, and sends the request to the
  P4Runtime server.

- A GetTableEntry function initializes a ReadRequest,
  prepares the TableEntry, sends the request to the
  P4Runtime server, and returns the response.

- A DoConfigEntry function implements the core logic of
  an ovsp4rt_table_entry C API. It may make one or more
  ConfigTableEntry or GetTableEntry calls.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Update C++ API functions to return absl::Status (#734)

b79ae6a

- Modified the functions in the internal C++ API to return
  `absl::Status`, allowing a test program to verify whether
  the function encountered an error.

- Updated the C API wrappers to ignore the returned Status
  explicitly. The public APIs currently have a `void` return
  type.

These changes only apply when BUILD_CLIENT is enabled.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>


          [ovsp4rt] Implement HaveTableEntry predicates

d6795e3

- Implemented `HaveTableEntry` predicates as wrappers around
  the `GetTableEntry` functions. Modified the code to use the
  predicates when the purpose of the read request is to test
  for the existence of an entry.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>

5abeel force-pushed the main branch from c8e36a7 to 1c60347 Compare

January 24, 2025 16:34

ffoulkes closed this

ffoulkes deleted the HaveTableEntry branch

January 24, 2025 20:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5abeel Awaiting requested review from 5abeel 5abeel will be requested when the pull request is marked ready for review 5abeel is a code owner

n-sandeep Awaiting requested review from n-sandeep n-sandeep will be requested when the pull request is marked ready for review n-sandeep is a code owner

vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp will be requested when the pull request is marked ready for review vsureshkumarp is a code owner

Namrata-intel Awaiting requested review from Namrata-intel Namrata-intel will be requested when the pull request is marked ready for review Namrata-intel is a code owner

weiqiand Awaiting requested review from weiqiand weiqiand will be requested when the pull request is marked ready for review weiqiand is a code owner

Labels

None yet