Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove p4cpconfig script #705

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Remove p4cpconfig script #705

merged 2 commits into from
Nov 4, 2024

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Nov 3, 2024

  • Removed the experimental p4cpconfig script. It has been superseded by cmake presets.

@ffoulkes
Remove p4cpconfig script
652d75c 
- Removed the experimental p4cpconfig script. It has been
  superseded by cmake presets.

Signed-off-by: Derek Foster <derek.foster@intel.com>
5abeel
5abeel approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit ee2919d into main Nov 4, 2024
11 checks passed
@ffoulkes ffoulkes deleted the p4cpconfig branch November 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @5abeel